Breaking/tao 4814 atomic bundles #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oatymart
previously approved these changes
Oct 23, 2018
There was a problem hiding this comment.
No issues found with the versions or bundles.
Edit: I missed something: npx grunt taomonitoringbundle failed:
Start bundling
Optimize css none.
>> taoMonitoring/loader/taoMonitoring.bundle.js bundled with 3 modules
Bundling done
Start transform
>> Error: ENOENT: no such file or directory, open 'taoMonitoring/views/js/loader/taoMonitoring.min.js'
Fatal error: Unable transform your code
I'm not sure why, but it seems like the bundle wasn't saved, my taoMonitoring/views/js folder contains only a controller folder.
|
@oatymart fixed. Could you please verify again. |
oatymart
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the extension to atomic bundles
Requires :